docs: replace deprecated PingCAP domains by wuhuizuo · Pull Request #67522 · pingcap/tidb

wuhuizuo · 2026-04-02T10:48:55Z

What problem does this PR solve?

Issue Number: close #67527

Problem Summary:

download.pingcap.org is being deprecated in favor of download.pingcap.com, but TiDB still has old-domain references in Dumpling install/docs and BR test download helpers on master.

What changed and how does it work?

replace deprecated download.pingcap.org references with download.pingcap.com in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
keep existing paths and current master behavior unchanged

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Manual test steps:

git diff --check
verify no remaining old-domain references in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
curl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gz
curl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gz
curl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gz
curl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz
curl -I https://download.pingcap.com/tidb-master-linux-amd64.tar.gz
curl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gz
curl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz
linked tracking issue #67527 is labeled type/compatibility

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

none

Summary by CodeRabbit

Chores
- Updated several download links to use the current PingCAP download domain across installation and test-related scripts.
Documentation
- Aligned setup instructions with the new download URLs for required TiDB ecosystem components.

pantheon-ai · 2026-04-02T10:49:01Z

Review Complete

Findings: 0 issues
Posted: 0
Duplicates/Skipped: 0

_{ℹ️ Learn more details on Pantheon AI.}

tiprow · 2026-04-02T10:49:09Z

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-04-02T10:49:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 991648cb-1d44-4cf1-8c5b-84d70638ea50

📥 Commits

Reviewing files that changed from the base of the PR and between 6d24f8e and b730737.

📒 Files selected for processing (1)

dumpling/install.sh

🚧 Files skipped from review as they are similar to previous changes (1)

dumpling/install.sh

📝 Walkthrough

Walkthrough

PingCAP download URLs were updated from download.pingcap.org to download.pingcap.com in BR tooling, dumpling scripts, and dumpling docs. The existing download, extraction, and file-placement behavior stays the same.

Changes

PingCAP download domain migration

Layer / File(s)	Summary
Installer URL update `dumpling/install.sh`	The dumpling installer switches the toolkit download host to `download.pingcap.com` while preserving the archive name and extraction flow.
BR and dumpling reference updates `br/tests/download_tools.sh`, `dumpling/README.md`	BR test download URLs and dumpling README examples are updated to `download.pingcap.com` for the referenced nightly artifacts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop-hop, the links are bright,
From old .org to new .com light,
Same tarballs, same neat trail,
Fresh burrow paths that never fail!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: replacing deprecated PingCAP domains in docs and scripts.
Description check	✅ Passed	The description matches the template well, includes the required issue reference, change summary, checklist, and release note section.
Linked Issues check	✅ Passed	The PR updates the three requested files and keeps behavior unchanged, matching the linked issue's master-side scope.
Out of Scope Changes check	✅ Passed	The changes stay focused on replacing deprecated domains, with no meaningful unrelated code introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/update-pingcap-domains-master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dumpling/README.md`:
- Around line 32-34: Update the download URL for `bin/sync_diff_inspector` in
the README so it uses HTTPS instead of HTTP: replace
`http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
with
`https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
to match the other entries (`bin/tidb-server`, `bin/tidb-lightning`) and avoid
the HTTP->HTTPS redirect.

🪄 Autofix (Beta)

✅ Autofix completed

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 20910d86-9f5e-43c5-a765-0ae2c7c51abf

📥 Commits

Reviewing files that changed from the base of the PR and between 4d20c4a and 2caf375.

📒 Files selected for processing (3)

br/tests/download_tools.sh
dumpling/README.md
dumpling/install.sh

pantheon-ai

✅ Code looks good. No issues found.

coderabbitai · 2026-04-02T11:24:54Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

dumpling/README.md

Commit: 6d24f8e1b56e458aff2faef581a96db3183c2371

The changes have been pushed to the fix/update-pingcap-domains-master branch.

Time taken: 1m 46s

Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

codecov · 2026-04-02T12:15:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.4929%. Comparing base (d568a85) to head (b730737).
⚠️ Report is 98 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #67522        +/-   ##
================================================
- Coverage   76.3213%   75.4929%   -0.8285%     
================================================
  Files          2041       2063        +22     
  Lines        562689     616060     +53371     
================================================
+ Hits         429452     465082     +35630     
- Misses       132324     145666     +13342     
- Partials        913       5312      +4399

Flag	Coverage Δ
integration	`45.8996% <ø> (+6.1709%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`61.4579% <ø> (+0.9969%)`	⬆️
parser	`∅ <ø> (∅)`
br	`61.1131% <ø> (-1.6774%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wuhuizuo · 2026-04-07T04:26:03Z

/retest

tiprow · 2026-04-07T04:26:27Z

@wuhuizuo: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wuhuizuo · 2026-05-06T08:16:56Z

/test ?

ti-chi-bot · 2026-05-06T08:17:00Z

@wuhuizuo: The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-build-next-gen

/test pull-integration-e2e-test

/test pull-integration-realcluster-test-next-gen

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-mysql-client-test-next-gen

/test pull-unit-test-ddlv1

/test pull-unit-test-next-gen

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-br-integration-test-next-gen

/test pull-check-deps

/test pull-common-test

/test pull-e2e-test

/test pull-error-log-review

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-ddl-test-next-gen

/test pull-integration-e2e-test-next-gen

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-mysql-test-next-gen

/test pull-sqllogic-test

/test pull-tiflash-integration-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_build_next_gen

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_integration_realcluster_test_next_gen

pingcap/tidb/pull_mysql_client_test

pingcap/tidb/pull_mysql_client_test_next_gen

pingcap/tidb/pull_unit_test_next_gen

pull-check-deps

pull-error-log-review

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wuhuizuo · 2026-05-06T08:17:16Z

/test check-dev2

ti-chi-bot · 2026-06-08T06:56:15Z

@wuhuizuo: The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-build-next-gen

/test pull-integration-e2e-test

/test pull-integration-realcluster-test-next-gen

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-mysql-client-test-next-gen

/test pull-unit-test-ddlv1

/test pull-unit-test-next-gen

/test unit-test

The following commands are available to trigger optional jobs:

/test canary-long-unit-test

/test canary-unit-test

/test pull-br-integration-test-next-gen

/test pull-check-deps

/test pull-common-test

/test pull-e2e-test

/test pull-error-log-review

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-ddl-test-next-gen

/test pull-integration-e2e-test-next-gen

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-mysql-test-next-gen

/test pull-sqllogic-test

/test pull-tiflash-integration-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_build_next_gen

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_integration_realcluster_test_next_gen

pingcap/tidb/pull_mysql_client_test

pingcap/tidb/pull_mysql_client_test_next_gen

pingcap/tidb/pull_unit_test_next_gen

pull-check-deps

pull-error-log-review

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2026-06-08T06:56:49Z

@wuhuizuo: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wuhuizuo · 2026-06-08T06:57:06Z

/test canary-unit-test

tiprow · 2026-06-08T06:57:29Z

@wuhuizuo: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test canary-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wuhuizuo · 2026-06-09T09:06:19Z

/test check-dev2

tiprow · 2026-06-09T09:06:47Z

@wuhuizuo: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-06-26T02:30:37Z

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
canary-unit-test	`5d8e201`	link	false	`/test canary-unit-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

wuhuizuo · 2026-06-26T03:28:43Z

/retest

the mysql-test has flaky tests.

ti-chi-bot · 2026-06-26T06:04:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~br/OWNERS~~ [Leavrth]
~~dumpling/OWNERS~~ [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-06-26T06:04:37Z

[LGTM Timeline notifier]

Timeline:

2026-06-26 05:59:38.313036415 +0000 UTC m=+272861.976261938: ☑️ agreed by D3Hunter.
2026-06-26 06:04:36.280915498 +0000 UTC m=+273159.944141011: ☑️ agreed by Leavrth.

wuhuizuo · 2026-06-26T06:06:24Z

/cherry-pick release-nextgen-202603
/cherry-pick release-nextgen-20260511

ti-chi-bot · 2026-06-26T06:06:26Z

@wuhuizuo: once the present PR merges, I will cherry-pick it on top of release-nextgen-202603/release-nextgen-20260511 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-nextgen-202603
/cherry-pick release-nextgen-20260511

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2026-06-26T07:10:38Z

@wuhuizuo: new pull request created to branch release-nextgen-202603: #69481.

Details

In response to this:

/cherry-pick release-nextgen-202603
/cherry-pick release-nextgen-20260511

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2026-06-26T07:11:18Z

@wuhuizuo: cannot checkout release-nextgen-20260511: error checking out release-nextgen-20260511: exit status 1. output: error: pathspec 'release-nextgen-20260511' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-nextgen-202603
/cherry-pick release-nextgen-20260511

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

wuhuizuo · 2026-06-26T07:26:48Z

/cherry-pick release-nextgen-20251011

ti-chi-bot · 2026-06-26T07:27:33Z

@wuhuizuo: new pull request created to branch release-nextgen-20251011: #69483.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

docs: replace deprecated PingCAP domains

2caf375

ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026

ti-chi-bot Bot added component/dumpling This is related to Dumpling of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026

coderabbitai Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread dumpling/README.md Outdated

pantheon-ai Bot reviewed Apr 2, 2026

View reviewed changes

fix: apply CodeRabbit auto-fixes

6d24f8e

Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

wuhuizuo changed the title ~~docs: replace deprecated PingCAP domains~~ docs: replace deprecated PingCAP domains | pd=@master_linux_amd64 May 6, 2026

pingcap deleted a comment from tiprow Bot May 6, 2026

ti-chi-bot changed the title ~~docs: replace deprecated PingCAP domains | pd=@master_linux_amd64~~ docs: replace deprecated PingCAP domains May 8, 2026

ti-chi-bot Bot added the do-not-merge/needs-linked-issue label May 8, 2026

wuhuizuo commented Jun 26, 2026

View reviewed changes

Comment thread dumpling/install.sh Outdated

Apply suggestion from @wuhuizuo

b730737

wuhuizuo marked this pull request as ready for review June 26, 2026 02:21

ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026

D3Hunter approved these changes Jun 26, 2026

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2026

Leavrth approved these changes Jun 26, 2026

View reviewed changes

ti-chi-bot Bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2026

ti-chi-bot Bot merged commit 2102bfe into master Jun 26, 2026
39 of 40 checks passed

ti-chi-bot Bot deleted the fix/update-pingcap-domains-master branch June 26, 2026 07:09

ti-chi-bot mentioned this pull request Jun 26, 2026

docs: replace deprecated PingCAP domains (#67522) #69481

Open

13 tasks

ti-chi-bot mentioned this pull request Jun 26, 2026

docs: replace deprecated PingCAP domains (#67522) #69483

Open

13 tasks

Uh oh!

Conversation

wuhuizuo commented Apr 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Summary by CodeRabbit

Uh oh!

pantheon-ai Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiprow Bot commented Apr 2, 2026

Uh oh!

coderabbitai Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pantheon-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes Applied Successfully

Uh oh!

codecov Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wuhuizuo commented Apr 7, 2026

Uh oh!

tiprow Bot commented Apr 7, 2026

Uh oh!

wuhuizuo commented May 6, 2026

Uh oh!

ti-chi-bot Bot commented May 6, 2026

Uh oh!

wuhuizuo commented May 6, 2026

Uh oh!

ti-chi-bot Bot commented Jun 8, 2026

Uh oh!

tiprow Bot commented Jun 8, 2026

Uh oh!

wuhuizuo commented Jun 8, 2026

Uh oh!

tiprow Bot commented Jun 8, 2026

Uh oh!

wuhuizuo commented Jun 9, 2026

Uh oh!

tiprow Bot commented Jun 9, 2026

Uh oh!

Uh oh!

ti-chi-bot Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wuhuizuo commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot Bot commented Jun 26, 2026

Uh oh!

ti-chi-bot Bot commented Jun 26, 2026

[LGTM Timeline notifier]

Uh oh!

wuhuizuo commented Jun 26, 2026

Uh oh!

ti-chi-bot commented Jun 26, 2026

Uh oh!

Uh oh!

ti-chi-bot commented Jun 26, 2026

Uh oh!

ti-chi-bot commented Jun 26, 2026

wuhuizuo commented Apr 2, 2026 •

edited by coderabbitai Bot

Loading

pantheon-ai Bot commented Apr 2, 2026 •

edited

Loading

coderabbitai Bot commented Apr 2, 2026 •

edited

Loading

coderabbitai Bot left a comment •

edited

Loading

coderabbitai Bot commented Apr 2, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited

Loading

ti-chi-bot Bot commented Jun 26, 2026 •

edited

Loading

wuhuizuo commented Jun 26, 2026 •

edited

Loading